-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question mode usage feedback updates. #9155
Conversation
@yuehuang010 , could I ask you to fix the build? |
Spinned of from the #8881 changes |
Hi @yuehuang010, The PR looks good to me, but could you reply to @Forgind questions above? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I'm still opinionated on having a dedicated error resource string for failed incrementality check. If that's added - I'll sign off. I'm fine to be voted-off (hence I'm not requesting the change). Or if there is a good reason not to have a separate string for that - I'm ready to listen for reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have couple comments - but those are just minor suggestions for consideration. Feel free to resolve those.
Other than that - I'm happy with the current state.
Thank you!
Updating a task behavior to avoid False positives.
After using /question switch on several repro, I am changing a few tasks to reduce False Positive. These task will continue perform there operations as in a normal build. If they impact the incremental build, then it would appear in downstream error. These task should log there file activity so that it could be traced.
Touch and Delete tasks - demote error to warning.
WriteLinesToFile Task - remove questioning when WriteOnlyWhenDifferent is false.
GenerateResource Task - Fix missing message.